Skip to content

feat: add envoy-admin-forward make target#815

Open
DCchoudhury15 wants to merge 1 commit intoKuadrant:mainfrom
DCchoudhury15:expose-envoy-ui
Open

feat: add envoy-admin-forward make target#815
DCchoudhury15 wants to merge 1 commit intoKuadrant:mainfrom
DCchoudhury15:expose-envoy-ui

Conversation

@DCchoudhury15
Copy link
Copy Markdown

@DCchoudhury15 DCchoudhury15 commented Apr 28, 2026

Fixes #325

Changes proposed in this pull request:

  • Added a new envoy-admin-forward make target under the Debug section to expose the Envoy Admin UI on localhost:15000.
  • Updated the local-env-setup, local-env-setup-olm, and dev targets to print a helpful message notifying developers that they can run this new command.

This addresses the maintainer's suggestion to provide a make target for the kubectl port-forward command.

Summary by CodeRabbit

  • New Features

    • Added a command to quickly port-forward the Envoy Admin UI to localhost:15000 for local development access.
  • Chores

    • Enhanced local environment setup with improved guidance for accessing the Envoy Admin interface.

Signed-off-by: DCchoudhury15 <divyanshuchoudhury3@gmail.com>
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 28, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 6e7b04b8-e9cd-4404-a2cf-ad1ba68556c6

📥 Commits

Reviewing files that changed from the base of the PR and between b7cc91e and 87bbc83.

📒 Files selected for processing (1)
  • Makefile

📝 Walkthrough

Walkthrough

A new envoy-admin-forward make target is added to enable port-forwarding of the Envoy Admin interface to localhost:15000 against the mcp-gateway-istio deployment in the gateway-system namespace, with user-facing URL guidance printed before execution.

Changes

Cohort / File(s) Summary
Make Target Addition
Makefile
Added envoy-admin-forward phony target to port-forward Envoy Admin UI to localhost:15000 with informational output.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: adding a new make target for envoy-admin-forward.
Linked Issues check ✅ Passed The PR addresses issue #325 by providing a make target for port-forwarding to the Envoy Admin UI, meeting the core objective.
Out of Scope Changes check ✅ Passed All changes (new make target and updates to existing targets) are directly related to exposing the Envoy Admin UI.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Idea: Expose the Envoy admin UI

1 participant