Standardize configuration defaults - #36
Closed
KulmanD wants to merge 4 commits into
Closed
Conversation
This was referenced Jul 26, 2026
Owner
Author
|
Superseded by draft PR #40, which contains this change, its performance evidence, the complete accepted integration, and passing final CI. Closing this draft without merging avoids duplicate commits. The branch is intentionally retained for isolated comparison and deferred measurements. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
config/defaults.jsonmaxScrollStepto the compiled value of8Resources/defaults.jsonwithout parsing it at runtimeWhy
The repository previously shipped a personal filename with
maxScrollStep: 5while both compiled defaults used8. The app bundled that unused file under another defaults name, creating three places that could drift.Preliminary footprint
The release helper remains exactly 432,552 bytes, identical in size to the frozen runtime baseline. There is no runtime parser, linked defaults module, resource lookup, timer, thread, or config reread. The first linked-module design was discarded because it added 46,032 bytes.
Testing
--checkLimitations and follow-up
Generated Swift files are checked in so normal source builds require no generation step. Contributors changing
config/defaults.jsonmust runswift scripts/generate-config-defaults.swift; CI enforces this.Refs #26