WIP: improve node menu performance #3452
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dannyvw
reviewed
Oct 14, 2024
| * | ||
| * @return NodeMenuItem[] | ||
| */ | ||
| public function getChildren(Node $node, $includeHiddenFromNav = true) |
There was a problem hiding this comment.
Remove array_filter also in https://github.com/Kunstmaan/KunstmaanBundlesCMS/blob/7.x/src/Kunstmaan/NodeBundle/Helper/NodeMenuItem.php#L211 and use the var $includeHiddenFromNav
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP PR to improve the performance of the NodeMenu class. This is early WIP and not fully tested. Feel free to test this and/or use the branch as a base and finish the improvements!