Add redirect querystring check and utf8 requirement #3508
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mart-insiders
force-pushed
the
redirect-with-query
branch
from
b5df318 to
99e56e0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug 1.
A redirect with queryparameters in target will duplicate its queryparameters if the source is itself. This is only required when redirecting to an external source.
Also, only appending queryparameters should be required if the redirect has a queryparameter in its target.
Bug 2.
When redirecting with a wildcard, a url which requires UTF8 is not always properly configured. This causes a 500 error when visiting the redirect. Checking the utf8 preg_match with the decoded routePath will fix this problem.
Test cases are added for both bugs.