Buzz-pbox/patch-1 #61
Conversation
pboxx
commented
Aug 28, 2015
pboxx
commented
- Incorporated Inge's latest wrappers (refactored to e.g. meet naming conventions).
- Replaced ushort tag values and hard-coded enums with a parsing functionality of the EAxian XML that contains the catalog categories and tags. Tags are deserialized into a custom class which is used instead of the ushort/values values. Also included is a custom editor to edit the value in the grid.
- Edited OBJD to correctly read/display EmotionEnvironmentTag indexes
- Added XML resource with tag information to project.
|
Why to change the entire implementation? |
|
Not sure which implementation you mean; flags or wrappers. Inge's wrappers are more complete regarding the semantic information like "PlacementFlags" vs. Unknown or something. pbox and I refactored them to be a little more in line with the usual C# conventions, though. The tag thing is because the previous implementation was a PITA (I was told) to use, because you had a dropdown with 1677 elements to choose from. It was also hard-coded while now you just need to drop the new resource into the S4pe folder and have the most current reincarnation of the EAxian tags. BTW: There was an issue with the output directory of the new project in the first version of this request. I just fixed it and pbox updated the pull request. The project references of the solution seem to be a mess, though, with hard references to the compiled assemblies instead of the projects. That's why the output directory of each project even matters. I may have a look at that at some point. |
|
The pull-request changed the way that most catalog resources behave. The current implementation has self-clone feature. |
|
Changing the way that the catalog resources behave is exactly the point of this. Regarding the clone feature, do you mean the Alex Burtsev stuff that is used in COBJ? If so: what is the actual advantage of that? It would probably not be a big deal to move that over to Inge’s version, I just don’t know of anything that doesn’t work in hers. |
Image export corrected and available as a resource helper
Fixed to accept STBLs with incorrect (non-EA) total string length generated by TSRW (works fine in-game), updated to include flags for each string
…headers * Update checking now directs to the s4ptacle release page and supports more complicated version strings. * The dialog that is shown when a newer version is found on the release page, now asks the user whether to visit the download page. * Updated the copyright headers of the touched files to reflect contributors.
…added to packages (fallbackObjectKey will be instantiated as empty TGIBlock instead of being left null)
Update with new and corrected file types on behalf of Inge.
Updated with info from the EAxian .bt
Update with additional flag lists from EA template update 2012-02-12
…es the file open dialog show an entirely different dialog
Fixed bugs in write, in read/write of packed frame indices, fixed addition of empty CLIP and CLIP parts.
Fixed reversed index order in one type of Frame
Mainly removing all the TS3 types, also adding a few missing ones
Conflicts: README.md
Add link to 0.4.4-beta
