fix(typing): accept a built JsonValue in init_connection_params - #367
Open
Danipulok wants to merge 1 commit into
Open
fix(typing): accept a built JsonValue in init_connection_params#367Danipulok wants to merge 1 commit into
JsonValue in init_connection_params#367Danipulok wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Client(init_connection_params=...)is annotatedOptional[dict], but a builtJsonValueworks and is arguably the more direct thing to pass.
session.py:195converts only when thevalue is a
dict:Anything else goes straight into
InvokeWithLayer(..., params=init_connection_params). So acaller who has already built a
raw.types.JsonObject— because they wanted control over thevalue types, or because they are forwarding one they received — passes it, it works, and
every type checker and IDE marks the call as wrong.
The change
The annotation, and the docstring line above it:
No behaviour moves: the
isinstancebranch already draws exactly this distinction, and thisonly writes down the half of it that was missing.