fix(typing): reword the comment mypy reads as a # type: comment - #370
Open
Danipulok wants to merge 1 commit into
Open
fix(typing): reword the comment mypy reads as a # type: comment#370Danipulok wants to merge 1 commit into
mypy reads as a # type: comment#370Danipulok wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
mypycannot check this project at all. One run, on a clean tree:The file parses fine and every other tool reads it. What
mypychokes on is a comment:A comment that begins
# type:is a PEP 484 type comment, somypyparses the rest of theline as a type expression, fails, and stops. It reports the one syntax error and checks
nothing else in the tree.
The change
The comment says the same thing, starting from a word instead of from
type::No code changes. Afterwards:
That number is what the annotations actually look like today, and it is a separate matter —
this only makes it visible.