-
Notifications
You must be signed in to change notification settings - Fork 92
WIP feat:MCP Support init #798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Raj Patil <[email protected]>
Signed-off-by: Raj Patil <[email protected]>
Signed-off-by: Raj Patil <[email protected]>
Signed-off-by: Raj Patil <[email protected]>
Signed-off-by: Raj Patil <[email protected]>
Signed-off-by: Raj Patil <[email protected]>
Signed-off-by: Raj Patil <[email protected]> fieldalignment also occurs in the enable section and buildssa raises an error with `golangci-lint config verify` leading to failed ci runs need to review if they are correct
@all-contributors please add @rajp152k for code |
I've put up a pull request to add @rajp152k! 🎉 |
Adds @rajp152k as a contributor for code. This was requested by elliotxx [in this comment](#798 (comment)) --------- Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
Signed-off-by: Raj Patil <[email protected]>
Signed-off-by: Raj Patil <[email protected]>
Signed-off-by: Raj Patil <[email protected]>
Signed-off-by: Raj Patil <[email protected]>
Signed-off-by: Raj Patil <[email protected]> mcp-golang does not implement SSE explictly yet and that section is completely commented out/under developement. see <https://github.com/metoro-io/mcp-golang/blob/main/transport/sse/sse_server.go>
Signed-off-by: Raj Patil <[email protected]>
Signed-off-by: Raj Patil <[email protected]>
Signed-off-by: Raj Patil <[email protected]>
go 1.22 | ||
go 1.23 | ||
|
||
toolchain go1.23.5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this line necessary?
@rajp152k Hi, I left a comment, and there are some problems found by CI, which you need to see. |
Hi, yes I'm still structuring the code and am deliberately making the CI fail with the WIP prefix for now Will fix them shortly after a semantically complete commit, an aware where they are failing Apologies for the confusion |
Adds @rajp152k as a contributor for code. This was requested by elliotxx [in this comment](#798 (comment)) --------- Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
@rajp152k Hey, bro, I recently developed an mcp server for converting favicon (https://github.com/elliotxx/favicon-mcp-server), just for practice and to get familiar with the mcp development process. Is there any entry point for me to participate in the development? |
Hi @elliotxx , apologies for the delays.. Was afk for a while (dislocated a shoulder) I'll get back into this shortly |
@rajp152k Bro, I'm sorry to hear this news. How is your health recovering now? And, I have been a bit busy lately, which has caused my response to messages to be a bit slow. (sad) However, I think we can work together to develop the MCP server in April and strive to complete it! |
Actually there are a couple of ligament tears and an impacted fracture, so have a surgery scheduled tomorrow I'll be walking out in a couple of days and would be able to type so yes, we can get this done.. |
@rajp152k The body is important, please take care of yourself first. I don't know how I can help, but I will pray for a smooth surgery from afar 🙏 |
Thank you, is a minimally invasive arthroscopy so I should be back soon but really appreciate the concern |
hi @elliotxx , I can type again so will resume contribs shortly thank you for your patience |
Welcome back, bro! Hope everything is fine. Feel free to ping me if needed. |
What type of PR is this?
/kind feature
What this PR does / why we need it:
MCP functionalities support init
Which issue(s) this PR fixes:
inits progress towards #658
generic discussions posted in #675
originally reviewed and approved by @elliotxx in #795 for further progress
this is a WIP PR to track and discuss the progress towards MCP integration and is not meant to be merged yet