Skip to content

WIP feat:MCP Support init #798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 17 commits into
base: main
Choose a base branch
from
Open

Conversation

rajp152k
Copy link
Contributor

@rajp152k rajp152k commented Feb 17, 2025

What type of PR is this?

/kind feature

What this PR does / why we need it:

MCP functionalities support init

Which issue(s) this PR fixes:

inits progress towards #658
generic discussions posted in #675
originally reviewed and approved by @elliotxx in #795 for further progress

this is a WIP PR to track and discuss the progress towards MCP integration and is not meant to be merged yet

@rajp152k rajp152k changed the title [WIP] MCP Support init feat:[WIP] MCP Support init Feb 17, 2025
Signed-off-by: Raj Patil <[email protected]>

fieldalignment also occurs in the enable section and buildssa raises an
error with `golangci-lint config verify` leading to failed ci runs

need to review if they are correct
@elliotxx
Copy link
Collaborator

@all-contributors please add @rajp152k for code

Copy link
Contributor

@elliotxx

I've put up a pull request to add @rajp152k! 🎉

elliotxx pushed a commit that referenced this pull request Feb 22, 2025
Adds @rajp152k as a contributor for code.

This was requested by elliotxx [in this
comment](#798 (comment))

---------

Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
@rajp152k rajp152k changed the title feat:[WIP] MCP Support init WIP feat:MCP Support init Feb 23, 2025
go 1.22
go 1.23

toolchain go1.23.5
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this line necessary?

@elliotxx
Copy link
Collaborator

@rajp152k Hi, I left a comment, and there are some problems found by CI, which you need to see.
I haven't seen the effect of mcp-go yet, maybe I'll wait for you to go further
If there is something I and others can participate in, you can directly assign issue

@rajp152k
Copy link
Contributor Author

Hi, yes

I'm still structuring the code and am deliberately making the CI fail with the WIP prefix for now

Will fix them shortly after a semantically complete commit, an aware where they are failing

Apologies for the confusion

fanfan-yu pushed a commit that referenced this pull request Mar 5, 2025
Adds @rajp152k as a contributor for code.

This was requested by elliotxx [in this
comment](#798 (comment))

---------

Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
@elliotxx
Copy link
Collaborator

@rajp152k Hey, bro, I recently developed an mcp server for converting favicon (https://github.com/elliotxx/favicon-mcp-server), just for practice and to get familiar with the mcp development process. Is there any entry point for me to participate in the development?

@rajp152k
Copy link
Contributor Author

Hi @elliotxx , apologies for the delays..

Was afk for a while (dislocated a shoulder)

I'll get back into this shortly

@elliotxx
Copy link
Collaborator

elliotxx commented Apr 2, 2025

Hi @elliotxx , apologies for the delays..

Was afk for a while (dislocated a shoulder)

I'll get back into this shortly

@rajp152k Bro, I'm sorry to hear this news. How is your health recovering now? And, I have been a bit busy lately, which has caused my response to messages to be a bit slow. (sad) However, I think we can work together to develop the MCP server in April and strive to complete it!

@rajp152k
Copy link
Contributor Author

rajp152k commented Apr 2, 2025

Actually there are a couple of ligament tears and an impacted fracture, so have a surgery scheduled tomorrow

I'll be walking out in a couple of days and would be able to type so yes, we can get this done..

@elliotxx
Copy link
Collaborator

elliotxx commented Apr 2, 2025

@rajp152k The body is important, please take care of yourself first. I don't know how I can help, but I will pray for a smooth surgery from afar 🙏

@rajp152k
Copy link
Contributor Author

rajp152k commented Apr 2, 2025

Thank you, is a minimally invasive arthroscopy so I should be back soon but really appreciate the concern

@rajp152k
Copy link
Contributor Author

rajp152k commented Apr 9, 2025

hi @elliotxx , I can type again so will resume contribs shortly
will keep you updated

thank you for your patience

@elliotxx
Copy link
Collaborator

elliotxx commented Apr 9, 2025

Welcome back, bro! Hope everything is fine. Feel free to ping me if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants