Skip to content

feat: support google cloud storage as backend #1356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 24, 2024

Conversation

ffforest
Copy link
Contributor

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?


Additional documentation e.g., design docs, usage docs, etc.:


@ffforest ffforest changed the title feat: support gcp as backend feat: support google cloud storage as backend Dec 24, 2024
@ffforest ffforest added this to the v0.14.0 milestone Dec 24, 2024
@ffforest ffforest linked an issue Dec 24, 2024 that may be closed by this pull request
@ffforest ffforest added the kind/feature Categorizes issue or PR as related to a new feature label Dec 24, 2024
@coveralls
Copy link

coveralls commented Dec 24, 2024

Pull Request Test Coverage Report for Build 12479867923

Details

  • 82 of 416 (19.71%) changed or added relevant lines in 8 files are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.5%) to 47.462%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/server/manager/workspace/util.go 0 6 0.0%
pkg/backend/backend.go 0 7 0.0%
pkg/backend/storages/google.go 9 26 34.62%
pkg/apis/api.kusion.io/v1/types.go 0 24 0.0%
pkg/project/storages/google.go 14 43 32.56%
pkg/engine/resource/graph/storages/google.go 0 68 0.0%
pkg/engine/release/storages/google.go 28 106 26.42%
pkg/workspace/storages/google.go 31 136 22.79%
Files with Coverage Reduction New Missed Lines %
pkg/engine/operation/parser/parser.go 3 79.27%
Totals Coverage Status
Change from base Build 12479830260: -0.5%
Covered Lines: 10624
Relevant Lines: 22384

💛 - Coveralls

@ffforest ffforest force-pushed the feat-support-gcp-backend branch from dd48efd to 362395d Compare December 24, 2024 09:31
Copy link
Contributor

@liu-hm19 liu-hm19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ffforest ffforest merged commit 95f3ed1 into KusionStack:main Dec 24, 2024
8 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/feature Categorizes issue or PR as related to a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feat: Support GCP as a backend storage
3 participants