Skip to content

fix 1358 Solve the problem of dependency change status not being updated #1362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

riven-blade
Copy link
Contributor

@riven-blade riven-blade commented Dec 26, 2024

What type of PR is this?

/kind bug

What this PR does / why we need it:

Resource dependency status maintenance and improvement needs

Which issue(s) this PR fixes:

Fixes #1358

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Solve the problem that the resources have not changed but the dependencies have changed, but the resource dependencies in status maintenance have not changed.

Additional documentation e.g., design docs, usage docs, etc.:


Copy link

CLA Assistant Lite bot:
Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


[email protected] seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You can retrigger this bot by commenting recheck in this Pull Request

@riven-blade
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@coveralls
Copy link

Pull Request Test Coverage Report for Build 12503183452

Details

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 47.474%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/engine/operation/graph/resource_node.go 0 1 0.0%
Totals Coverage Status
Change from base Build 12479976569: 0.01%
Covered Lines: 10627
Relevant Lines: 22385

💛 - Coveralls

@github-actions github-actions bot locked and limited conversation to collaborators Dec 26, 2024
@riven-blade riven-blade deleted the bugfix-1358 branch December 30, 2024 03:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: DependsOn in state does not update accordingly if resource is unchanged
2 participants