Skip to content

fix: modules and runs api #1364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 27, 2024
Merged

fix: modules and runs api #1364

merged 1 commit into from
Dec 27, 2024

Conversation

Yangyang96
Copy link
Contributor

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?


Additional documentation e.g., design docs, usage docs, etc.:


liu-hm19
liu-hm19 previously approved these changes Dec 27, 2024
Copy link
Contributor

@liu-hm19 liu-hm19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@coveralls
Copy link

Pull Request Test Coverage Report for Build 12514093561

Details

  • 20 of 43 (46.51%) changed or added relevant lines in 5 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.02%) to 47.681%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/infra/persistence/module_model.go 0 2 0.0%
pkg/infra/persistence/resource.go 5 7 71.43%
pkg/server/manager/resource/util.go 14 19 73.68%
pkg/server/manager/module/module_manager.go 0 14 0.0%
Files with Coverage Reduction New Missed Lines %
pkg/engine/operation/watch.go 1 82.76%
Totals Coverage Status
Change from base Build 12510813192: 0.02%
Covered Lines: 10858
Relevant Lines: 22772

💛 - Coveralls

Copy link
Contributor

@liu-hm19 liu-hm19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Yangyang96 Yangyang96 merged commit a3a9166 into main Dec 27, 2024
8 checks passed
@Yangyang96 Yangyang96 deleted the fix_api branch December 27, 2024 09:13
@github-actions github-actions bot locked and limited conversation to collaborators Dec 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants