Skip to content

chore: mask backend sensitive data #1373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

Yangyang96
Copy link
Contributor

What type of PR is this?

What this PR does / why we need it:

avoid displaying sensitive data to user

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?


Additional documentation e.g., design docs, usage docs, etc.:


@Yangyang96 Yangyang96 changed the title chore: mask backend sensitive information chore: mask backend sensitive data Jan 8, 2025
@coveralls
Copy link

coveralls commented Jan 8, 2025

Pull Request Test Coverage Report for Build 12663795420

Details

  • 31 of 72 (43.06%) changed or added relevant lines in 6 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 47.524%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/apis/api.kusion.io/v1/types.go 0 1 0.0%
pkg/server/handler/stack/handler.go 1 4 25.0%
pkg/server/handler/workspace/handler.go 2 8 25.0%
pkg/server/manager/backend/backend_manager.go 11 19 57.89%
pkg/domain/request/workspace_request.go 9 19 47.37%
pkg/server/manager/backend/util.go 8 21 38.1%
Totals Coverage Status
Change from base Build 12646796222: 0.02%
Covered Lines: 10958
Relevant Lines: 23058

💛 - Coveralls

ffforest
ffforest previously approved these changes Jan 8, 2025
Copy link
Contributor

@liu-hm19 liu-hm19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Yangyang96 Yangyang96 merged commit 823e9a9 into KusionStack:main Jan 8, 2025
8 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 8, 2025
@Yangyang96 Yangyang96 deleted the maskSecret branch January 8, 2025 06:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants