Skip to content

feat: support patcher removal for label and annotation #1374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

liu-hm19
Copy link
Contributor

@liu-hm19 liu-hm19 commented Jan 8, 2025

What type of PR is this?

/kind feature

What this PR does / why we need it:

This PR adds support for removal ability of label and annotation patcher.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?


Additional documentation e.g., design docs, usage docs, etc.:


@liu-hm19 liu-hm19 added the kind/feature Categorizes issue or PR as related to a new feature label Jan 8, 2025
@liu-hm19 liu-hm19 self-assigned this Jan 8, 2025
@coveralls
Copy link

Pull Request Test Coverage Report for Build 12667303362

Details

  • 12 of 20 (60.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.002%) to 47.508%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/generators/appconfiguration/app_configurations_generator.go 12 20 60.0%
Totals Coverage Status
Change from base Build 12664971436: 0.002%
Covered Lines: 10962
Relevant Lines: 23074

💛 - Coveralls

@liu-hm19 liu-hm19 merged commit e59a896 into KusionStack:main Jan 9, 2025
8 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/feature Categorizes issue or PR as related to a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants