Skip to content

Fixed qsql target added underscore #493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ecmel merged 1 commit into from
Jan 14, 2025
Merged

Fixed qsql target added underscore #493

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 11 additions & 5 deletions src/webview/components/kdbDataSourceView.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ export class KdbDataSourceView extends LitElement {
static styles = [shoelaceStyles, dataSourceStyles];

readonly vscode = acquireVsCodeApi();
private declare debounce;
declare private debounce;

isInsights = false;
isMetaLoaded = false;
Expand Down Expand Up @@ -318,7 +318,9 @@ export class KdbDataSourceView extends LitElement {
if (!this.qsqlTarget) {
this.qsqlTarget = value;
}
return html`<sl-option value="${value}">${value}</sl-option>`;
return html`<sl-option value="${encodeURIComponent(value)}"
>${value}</sl-option
>`;
});
}
return [];
Expand Down Expand Up @@ -816,12 +818,16 @@ export class KdbDataSourceView extends LitElement {
<div class="col">
<sl-select
label="Target"
.value="${live(this.qsqlTarget)}"
.value="${live(encodeURIComponent(this.qsqlTarget))}"
@sl-change="${(event: Event) => {
this.qsqlTarget = (event.target as HTMLSelectElement).value;
this.qsqlTarget = decodeURIComponent(
(event.target as HTMLSelectElement).value,
);
this.requestChange();
}}">
<sl-option .value="${live(this.qsqlTarget)}" .selected="${live(true)}"
<sl-option
.value="${live(encodeURIComponent(this.qsqlTarget))}"
.selected="${live(true)}"
>${this.qsqlTarget || "(none)"}</sl-option
>
<small
Expand Down
Loading