Skip to content

fix abnormal count of rows #503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Philip-Carneiro-KX merged 5 commits into from
Jan 23, 2025
Merged

fix abnormal count of rows #503

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
132c08f
fix anormal count of rows
Philip-Carneiro Jan 22, 2025
c92c750
remove evaluate changes
Philip-Carneiro Jan 23, 2025
5cc7505
remove count dependency from structuredText
Philip-Carneiro Jan 23, 2025
87bdede
add error string
Philip-Carneiro Jan 23, 2025
525980a
improve code readability
Philip-Carneiro Jan 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/commands/serverCommand.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1264,7 +1264,7 @@ export async function writeScratchpadResult(
let errorMsg;

if (result.error) {
errorMsg = result.errorMsg;
errorMsg = "Error: " + result.errorMsg;

if (result.stacktrace) {
errorMsg =
Expand Down
18 changes: 14 additions & 4 deletions src/services/resultsPanelProvider.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,14 +191,24 @@ export class KdbResultsViewProvider implements WebviewViewProvider {
}

updatedExtractRowData(results: StructuredTextResults) {
const { columns, count } = results;
const { columns } = results;
const columnsArray = Array.isArray(columns) ? columns : [columns];

let dataLength = 0;
if (columnsArray.length > 0) {
const firstColumnValues = columnsArray[0].values;
if (Array.isArray(firstColumnValues)) {
dataLength = firstColumnValues.length;
} else {
dataLength = 1;
}
}

const rowData: { [key: string]: any }[] = Array.from(
{ length: count },
{ length: dataLength },
() => ({}),
);

const columnsArray = Array.isArray(columns) ? columns : [columns];

columnsArray.forEach((column) => {
const { name, values } = column;
values.forEach((value, index) => {
Expand Down
Loading