Skip to content

[fix] Downgrade engine version to 1.96.0#604

Merged
ecmel merged 1 commit intodevfrom
ee-fixes
Jun 25, 2025
Merged

[fix] Downgrade engine version to 1.96.0#604
ecmel merged 1 commit intodevfrom
ee-fixes

Conversation

@ecmel
Copy link
Collaborator

@ecmel ecmel commented Jun 25, 2025

Changes introduced by this PR

  • Min required version of VS Code is 1.96.0

@ecmel ecmel self-assigned this Jun 25, 2025
"@types/semver": "^7.7.0",
"@types/sinon": "^17.0.4",
"@types/vscode": "^1.97.2",
"@types/vscode": "^1.96.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be 1.96.4? With the fixes for the version 1.96.0?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be inline with engine version which is 1.96.0 (https://www.npmjs.com/package/@types/vscode/v/1.96.0) 1.96.4 will get picked up by npm install.

@kx-sonarqube
Copy link

kx-sonarqube bot commented Jun 25, 2025

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@ecmel ecmel requested a review from Philip-Carneiro-KX June 25, 2025 12:26
@ecmel ecmel changed the title [fix ] Downgrade engine version to 1.96.0 [fix] Downgrade engine version to 1.96.0 Jun 25, 2025
@ecmel ecmel merged commit 42fdd1d into dev Jun 25, 2025
5 checks passed
@ecmel ecmel deleted the ee-fixes branch June 25, 2025 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants