Skip to content

[KXI-65355] refactoring the execution methods#662

Closed
Philip-Carneiro-KX wants to merge 46 commits intodevfrom
KXI-65355-2
Closed

[KXI-65355] refactoring the execution methods#662
Philip-Carneiro-KX wants to merge 46 commits intodevfrom
KXI-65355-2

Conversation

@Philip-Carneiro-KX
Copy link
Contributor

Changes introduced by this PR

  • Isolate the execution commands

@Philip-Carneiro-KX Philip-Carneiro-KX mentioned this pull request Aug 28, 2025
@ecmel
Copy link
Collaborator

ecmel commented Sep 1, 2025

For Insights Connections I have the following observations:

PyKX works on output tab but not on kdb results nor Notebooks.

import random
import pykx as kx
 
x = [5 * i for i in range(45)] 
y = list(range(45))  
z = random.choices(['a', 'b', 'c'], k=45) 

kx.q('{([] x;y;z)}', x, y, z)

Notebook gives the following error message:

Execution stopped.
response.data.data.map is not a function

kdb results view does not output anything.

Errors not showing correctly on notebooks:

'error

with the following output:

Execution stopped.
Cannot read properties of undefined (reading 'values')

I will test kdb+ connections today but I was not able test DAPs since I do not have a server with.kxi.qsqlenabled right now.

@Philip-Carneiro-KX

@ecmel
Copy link
Collaborator

ecmel commented Sep 12, 2025

@Philip-Carneiro-KX Populate scratchpad on DAP with Python is still not working. Test Notebook

Copy link
Collaborator

@ecmel ecmel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Populating scratchpad works on Notebooks but it notifies user with an information message, this information message should not be shown for notebooks.

  • Python output on DAP or DAP process is not using a table, the output should be the same as scratchpad output for the same Python code:

Screenshot 2025-09-18 at 16 04 21

Copy link
Collaborator

@ecmel ecmel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test Results

Test for KXI-65355-2 branch against 1.14.0 main branch.

Execution

Type kdb IE Scratchpad IE Q/SQL IE Populate SP
q file x
py file x
sql file x x
q cell
py cell
sql cell x x
datasource x x
Legend
Working
x Not working

Other

  • IE Populate SP shows superfluous information message for notebooks.
  • Background starting of IE Scratchpad notification status message is not shown when needed.
  • Notebook stop execution and connect offer can deadlock.

@Philip-Carneiro-KX

@kx-sonarqube
Copy link

kx-sonarqube bot commented Sep 22, 2025

@ecmel ecmel marked this pull request as draft September 26, 2025 07:55
@ecmel ecmel assigned ecmel and unassigned Philip-Carneiro-KX Sep 26, 2025
@ecmel ecmel removed their request for review September 26, 2025 07:57
@ecmel
Copy link
Collaborator

ecmel commented Oct 15, 2025

Closing for now for the small value added vs. surfaced bugs.

@ecmel ecmel closed this Oct 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants