Conversation
vcalescu
requested changes
Oct 21, 2025
vcalescu
approved these changes
Oct 21, 2025
|
nfarrell-kx
reviewed
Oct 21, 2025
| "scope": "machine", | ||
| "deprecationMessage": "This setting is deprecated, use kdb.hideSourceExpressions instead" | ||
| }, | ||
| "kdb.hideSourceExpressions": { |
Collaborator
There was a problem hiding this comment.
Do we need to handle copying the existing value from hideDetailedConsoleQueryOutput into this new setting?
Collaborator
Author
There was a problem hiding this comment.
deprecationMessage is set for the old setting and it is in change log as well and it is by default true so IMHO there is no need to copy the previous setting to the new one. Only the users who set this false will need to go to settings and change the new setting.
nfarrell-kx
approved these changes
Oct 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes introduced by this PR
Hide Detailed Console Query Outputsetting and added a newHide Source Expressionssetting.