Add Laravel 12 support #391
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice, I'd love to see this merged soon if possible. I'd also suggest updating the CI config file so CI is run on L12 and PHP 8.4 as well. |
|
@thejamescollins 👍 done. Thanks for suggestion. ❤️ |
|
Hi @Kyon147 would it be possible for you to review and merge this PR? Thanks so much |
|
Hmm can merge? |
|
I've been on holiday the last two weeks but will get this sorted this week. Thanks for the PR 🙏 |
|
Hi @Kyon147, Did you need any further help or assistance with this PR? Thank you 🙏 |
Kyon147
approved these changes
Mar 25, 2025
|
It is now in the latest release https://github.com/Kyon147/laravel-shopify/releases/tag/v23.0.0 |
|
@Kyon147 Thank you, Luke! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Laravel 12 support