Skip to content

Bump the default minimum toolchain to Java 17 #147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 29, 2023
Merged

Bump the default minimum toolchain to Java 17 #147

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8183dab
feat(common): Bump the default minimum toolchain to Java 17
zml2008 Aug 28, 2023
6339550
chore(common): Constantify
zml2008 Aug 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions indra-common/src/main/java/net/kyori/indra/internal/JavaToolchainVersionsImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,9 @@ public class JavaToolchainVersionsImpl implements JavaToolchainVersions {
private static final String STRICT_MULTIRELEASE_VERSIONS = "strictMultireleaseVersions";
private static final String CI = "CI";

private static final int DEFAULT_TARGET = 8;
private static final int DEFAULT_MINIMUM_TOOLCHAIN = 17;

private final Property<Integer> target;
private final Property<Integer> minimumToolchain;
private final Property<Boolean> strictVersions;
Expand All @@ -48,8 +51,8 @@ public class JavaToolchainVersionsImpl implements JavaToolchainVersions {

@Inject
public JavaToolchainVersionsImpl(final ObjectFactory objects, final ProviderFactory providers) {
this.target = objects.property(Integer.class).convention(8);
this.minimumToolchain = objects.property(Integer.class).convention(11);
this.target = objects.property(Integer.class).convention(DEFAULT_TARGET);
this.minimumToolchain = objects.property(Integer.class).convention(DEFAULT_MINIMUM_TOOLCHAIN);
this.strictVersions = objects.property(Boolean.class)
.convention(
Properties.forUseAtConfigurationTime(providers.gradleProperty(STRICT_MULTIRELEASE_VERSIONS))
Expand Down