Repository navigation
Retro #351: prod-text --matches-db, batch-edit pointers - #356
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes from the retro on #351 / #355:
scripts/prod-text.sh <slug> [--contains <file>] +scripts/prod-text.sh --matches-db <slug>... # prod EN+KO title/description/constraints vs CODEBITE_DB--matches-db:--containsneeds one text in both languages, so it couldn't guard V590–V592, which replace a different line per language in 48 problems. That check was hand-rolled (96 curls plus Python, and Python's own client got a 403 from production). Now it's one command, run on a database atorigin/master's migrations.replace/insertBeforeExample1and at--matches-db..claude/settings.jsonallowsscripts/prod-text.sh. The auto-mode classifier had blocked a subagent's reads of the public API.gh issue createinstead ofscripts/gh-ticket.sh.Evidence
--matches-dbdidn't exist, and production was compared by an ad-hoc script.After:
scripts/prod-text.test.shcovers a match, a drifted field named per language, a problem missing locally and a malformed slug, against stub curl and docker.scripts/run-script-tests.shpasses and shellcheck is clean.Merge Danger
Door: two-way
Blast Radius: tooling
It doesn't change application code. The permission rule only skips a prompt for a read-only GET of the public API.
🤖 Generated with Claude Code