Repository navigation
Walkthrough rule 2: catch shifted and derived vars items - #357
Merged
Merged
Conversation
A vars item now also fails when it follows a drawn value plus or minus 1, a span's exclusive length or a list in another order, or, following none, a drawn value a frame early or late (#300). Partial lists and positioned values kept only in vars become review items in add-walkthrough step 3. All 22 Walkthroughs pass unchanged. Closes #300 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #300.
varsRepeatingTheData(#273's second rule) now also catches avarsitem that repeats the data off by one frame or in a derived form.Message names the form, e.g.
pointer "right" of array "xs", plus 1,a value in map "counts", a frame late.whystill excuses an item from every form, and awhyrepeating nothing still fails.add-walkthrough step 3 lists what the test can't catch, each with its reason: a part of a drawn list in
vars, and a value with a position kept only invars.No derived form was dropped: none raised a false alarm. No tracer was regenerated: all 22 Walkthroughs pass unchanged.
Evidence
varsFixture()fail as not caught:item a frame late,item a frame early,item a pointer plus 1,item a pointer minus 1,item a span's exclusive length,item a list in another order→[]whykept by a new form, an item matching in one pair of frames. Breaking the two-pair threshold made that last case fail as it should.noVarsItemRepeatsAValueDrawnOnTheDatapasses on every Walkthrough;com.codebite.problem365/365, full backend suite green.Merge Danger
Door: two-way
Test and skill text only; no production code.
Blast Radius: tests
A future Walkthrough whose
varsitem follows the data off by one now failsnoVarsItemRepeatsAValueDrawnOnTheDatauntil its tracer draws it or gives it awhy.🤖 Generated with Claude Code