Embed pin: right-side overlay that does not shift the map#29
Merged
Conversation
When a country is pinned inside an embedded /embed iframe, render the detail panel as an absolute overlay anchored at the canvas top-right instead of pushing the map sideways or stacking it underneath. Key properties: - position: absolute so the pin is entirely out of the layout flow. Opening the pin does not change the canvas size, position or the rendered map (verified: Sweden's bounding rect is byte-identical before and after the pin opens in /embed?chrome=minimal). - Top offset is calc(36px + 0.5rem) when the toolbar is visible and 0.5rem when the toolbar is hidden, so the pin sits flush with the canvas top with equal 0.5rem inset from the right edge in both modes. - 'Open full profile -> ' link opens in a new tab so embedding hosts do not navigate away when a reader explores a country.
georgepadayatti
approved these changes
May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In embedded /embed iframes the country detail panel now renders as an absolute overlay anchored at the canvas top-right corner instead of pushing the map sideways or stacking it underneath.
Test plan