Windows updates to get vbcable working in latest windows runners#20
Windows updates to get vbcable working in latest windows runners#20sethvincent wants to merge 1 commit into
Conversation
- new setup_sound.ps1 script - add windows-2025, remove windows-2019 - use VBCABLE_Driver_Pack45 - change approach for testing device output
| set -xeo pipefail | ||
| python -m sounddevice | grep "[82] out" | ||
| name: Check that there is some output device | ||
| - run: sleep 10 |
There was a problem hiding this comment.
Can we keep the sleep in there? There must have been a reason we put it in there sleep at some point (I don't remember what it is offhand) so probably better to keep it and do the check twice.
Also the existing test made sure that there were actually output channels available, the test no longer does that. Looks like the output on Windows is:
< 4 Speakers (2- VB-Audio Virtual C, MME (0 in, 8 out)
so it should have still passed. So it's probably worth reverting these changes, or otherwise refactoring them to make sure they still check things as completely as they did before.
|
@sethvincent I updated the runner list in #26 and things appear to work in In any case, happy to take another look at this if you fix the merge conflicts |
2 participants
Hello! I rewrote the windows/setup_sound.ps1 script to be able to get/list audio devices in SDL3 tests.
Changes include:
I'm using these changes in an SDL3 bindings project that you can check out for proof it works.
The ps1 script changes are pretty substantial so I'm happy to make changes if needed; I'm worried about having changed something needed for your use case.