Ros2 open vocabulary - #428
Merged
Merged
Conversation
- Changed durability policy in mapping configuration to Transient Local. - Enhanced nav.launch.py with additional nodes for navigation and initial pose publishing. - Introduced label_locations.py for interactive map labeling. - Updated map.yaml with corrected origin coordinates. - Modified map.pgm to reflect new map data.
…ated OpenVocabNode for handling detection requests and responses. Updated ros2.def to use the latest ament_virtualenv without version pinning, now with colcon build withotu (--symlink-install pip requirements are automatically installled. Fixed existing setup.py files across various packages to support virtualenv installation. read markdown file for other info
jws-1
approved these changes
May 25, 2026
jws-1
left a comment
jws-1
left a comment
Member
There was a problem hiding this comment.
Thanks Michele! Looks good to me. I think we should just remove the .claude directory, and then I can merge this in :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
colcon build was failing for packages with pip dependencies due to two issues with ament_virtualenv 0.5.0:
Result: builds failed with Failed to find package.xml or requirements.txt cannot be found.
--symlink-install is incompatible with ament_virtualenv because colcon uses develop/editable install mode which skips the install cmdclass entirely — the virtualenv is never created. This is a known colcon behavior documented in Always use colcon build without --symlink-install for packages with pip deps. Read colcon/colcon-core#691
I have created a readme and added the two rows that specigy the path in the setup,py .