Bugfix cleanup rng omp #2404
Open
Bugfix cleanup rng omp #2404
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tbennun
reviewed
Dec 13, 2023
tbennun
left a comment
tbennun
left a comment
There was a problem hiding this comment.
Looks clean, but there is one comment about the ICC version of the globals
benson31
approved these changes
Feb 14, 2024
sequential and OMP parallel blocks. Added explict RNGs for OMP parallel blocks. Fixed the declaration and initialization of OMP RNGs when compiling in deterministic mode (which disables OMP parallel blocks). Refactored how the RNGs are saved to and loaded from checkpoints. Changed the creation of the I/O RNG banks so that there is one bank per I/O thread. Removed the option to explicitly set the number of I/O RNGs.
bvanessen
force-pushed
the
bugfix_cleanup_rng_omp
branch
from
440683a to
2382348
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.