Skip to content

Some changes necessary for bf16/fp16 updates in rocm #2480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 19, 2025
Merged

Some changes necessary for bf16/fp16 updates in rocm #2480

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions include/lbann/utils/impl/rocm.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@
#include "hipcub/block/block_reduce.hpp"
#endif // HYDROGEN_HAVE_CUB
#include <hip/hip_fp16.h>
#include <hip/hip_bf16.h>
#include <limits>
#endif // __HIPCC__

Expand Down Expand Up @@ -165,7 +166,7 @@ __device__ __forceinline__ T gpu_lib::block_reduce(T val)
#define WRAP_UNARY_ROCM_HALF_MATH_FUNCTION(func) \
__device__ __forceinline__ __half gpu_lib::func(__half const& x) \
{ \
return ::h##func(x); \
return h##func(x); \
}

// FIXME (trb): This is maybe not the best long-term solution, but it
Expand All @@ -190,7 +191,7 @@ WRAP_UNARY_ROCM_HALF_MATH_FUNCTION(exp)
// implementation could be:
__device__ __forceinline__ __half gpu_lib::expm1(__half const& x)
{
return ::__hsub(::hexp(x), ::__float2half(1.f));
return __hsub(hexp(x), __float2half(1.f));
}

WRAP_UNARY_ROCM_HALF_MATH_FUNCTION(log)
Expand All @@ -204,7 +205,7 @@ WRAP_UNARY_ROCM_HALF_MATH_FUNCTION(sin)
// accurate than a native implementation.
__device__ __forceinline__ __half gpu_lib::tan(__half const& x)
{
return ::__hdiv(::hsin(x), ::hcos(x));
return __hdiv(hsin(x), hcos(x));
}

WRAP_UNARY_ROCM_HALF_CAST_TO_FLOAT_MATH_FUNCTION(acos)
Expand Down Expand Up @@ -242,12 +243,12 @@ __device__ __forceinline__ bool gpu_lib::isfinite(__half const& x)
// Binary math functions
__device__ __forceinline__ __half gpu_lib::min(const __half& x, const __half& y)
{
return ::__hle(x, y) ? x : y;
return __hle(x, y) ? x : y;
}

__device__ __forceinline__ __half gpu_lib::max(const __half& x, const __half& y)
{
return ::__hle(x, y) ? y : x;
return __hle(x, y) ? y : x;
}

// Numeric limits
Expand Down
Loading