Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spike - #156

Draft
wants to merge 3 commits into
base: development
Choose a base branch
from
Draft

Spike - #156

wants to merge 3 commits into from

Conversation

FaisalHackney
Copy link
Contributor

@FaisalHackney FaisalHackney commented Aug 8, 2024

Link to JIRA ticket

HPT-289

Describe this PR

What is the problem we're trying to solve

This is a Spike PR to investigate how to run single test classes against multiple databases in Parallel

What changes have we introduced

Investigations into 2 methods
All the work is in the /spike289 and /spike289v2 folders

Recommendation would be to go with /spike289v2 solution as this has a cleaner approach with less duplication of test code

Copy link

gitguardian bot commented Aug 8, 2024

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
13348603 Triggered Generic Password a97fcb7 HousingFinanceInterimApi.Tests/V1/spike289v2/DatabaseContextFixture/DatabaseFixtureFactory.cs View secret
13348603 Triggered Generic Password 989e659 HousingFinanceInterimApi.Tests/V1/spike289v2/DatabaseContextFixture/DatabaseFixtureFactory.cs View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant