Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Finish renaming the DR1 and DR2 codes within the 'BaseOperatingBalanc… #171

Open
wants to merge 1 commit into
base: development
Choose a base branch
from
Open

Finish renaming the DR1 and DR2 codes within the 'BaseOperatingBalanc… #171

wants to merge 1 commit into from

Conversation

Duslerke
Copy link
Contributor

@Duslerke Duslerke commented Mar 14, 2025 •
edited
Loading

What:

  • Complete the renaming of the DR1 and DR2 code descriptions.

Why:

  • To avoid confusing the developers and API consumers for why the field names are named different to what's in the database.

Notes:

  • This continues the PRs HFSDatabaseObjects#160 and HFSDatabaseObjects#160
  • Looking back at these changes, it seems unlikely that we'll get this release before the end of 2025 financial year. As we're holding off from releasing the dotnet8 upgrade changes that would get released as part of this release.

@Duslerke Duslerke requested a review from a team as a code owner March 14, 2025 12:08
@Duslerke Duslerke requested a review from FaisalHackney March 14, 2025 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FaisalHackney FaisalHackney FaisalHackney approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Duslerke @FaisalHackney