Staging update #174
Open
Staging update #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
adamtry
commented
Apr 1, 2025
•
adamtry
commented
- Updated production authorizer ARN Update production authorizer ARN #173
- Added an update TA endpoint Update ta endpoint #167
- Upgraded to dotnet 8 .NET 6 -> 8 #163
- Some stored procedure tests
Feature/hpt 297 spike
* Remove useless launchsettings * Delete current test database folder * Upgrade test SDK * Add HFSDatabaseObjects submodule * Use submodule remote db makefile
Tests for this process, rewritten in Entity Framework. Runs on the EE Docker environment (make unit_db_ee) See sproc code: https://github.com/LBHackney-IT/HFSDatabaseObjects/blob/880959d860c087cde6f946f16834e8f5b2416c0a/stored_procedures/usp_LoadCashFile.sql What the stored procedure does is: Clears UPCashDump records associated with filenames that were unsuccessfully processed For the rest of the UPCashDump records that are unread, parses their FullText into various fields Inserts the parsed data into UPCashLoad Marks the processed UPCashDump records as read Other changes: Switch the DatabaseContext tests to use the Dockerised SQL Server database from the HFSDatabaseObjects module added in Add HFSDatabaseObjects submodule for unit test database #148 Added a helper class + methods to clear tables in reverse dependency order automatically. This can become a major headache if it needs to be done manually on each test, especially as the nesting grows larger. Fixed some database entities to ensure EF can create them from fixtures without errors. Cleared up redundant entries in the docker-compose.yml as part of preparation for using it to support running these tests in future
Speed up the HFS reports use case tests from ~15 minutes running time to ~1 minute by allowing file wait and retry durations to be modified. This cuts down the CI pipeline duration to ~2.5 minutes, as the reports UC tests were the bottleneck. The reports UC made use of hard time waits and retry intervals which ran far longer than is needed in unit tests that aren't connected to real infrastructure. This PR modifies the GenerateReportUseCase to take in optional sleepDuration and retryInterval params that retain the original values as defaults, but can be overridden in the tests or elsewhere in the application as needed. It also ensures the UC reports are generated and checked using a retry mechanism and a timeout similar to how it was already done in one of the reports, instead of just hard wait duration. Time calculations in the tests often assumed the default values for sleep and retry durations, so they have been modified accordingly.
Tests for this stored procedure Runs on the EE Docker environment (make unit_db_ee) See sproc code: https://github.com/LBHackney-IT/HFSDatabaseObjects/blob/880959d860c087cde6f946f16834e8f5b2416c0a/stored_procedures/usp_GetCashImportByDate.sql What the stored procedure does is: Takes in a startDate and endDate as parameters Gets CashDump records, parsing the date from the filename Using all suspense and non-suspense SSMiniTransaction records, creates a summed total transaction amount by rent group, and grand total Note: There are many assorted cases that could cause records to not be selected as part of the report, however these cases tend to be fairly trivial and still verbose to test effectively. I believe that only the happy path is worth testing for this process at this time.
trigger redeploy
Update Tenancy Agreement Details Endpoint
This change resolves a build failure because Serverless Framework 4 doesn't pick up globally installed modules. I'm not sure why this has changed (or how/if it's actually changed), but it's sensible to version the dependencies and installing the plugin using 'npm install' following the docs _also_ allows the command to succeed.
save changes made to ispresent and isterminated
Update ta endpoint
Serverless 4
In #162 I introduced `package.json` to manage Serverless plugins (because it's recommended by the docs and the existing approach failed in CI), however I failed to do two things: 1. Actually install Serverless 4. The change was _supposed_ to switch from using `npm install -g serverless@3` followed by executing `sls` to a single use of `npx --yes serverless deploy`. In #162 I removed the global install step but didn't update how we called serverless 🤦. 2. Removing the plugin install steps, so it attempted to install them twice 🤦. So, double facepalm. Sorry! This change resolves those two errors.
🤦 Fix serverless deploy command
In #163 we upgraded .Net from 6 to 8, but missed one reference in the CircleCI config, which caused the build to fail. This change fixes that.
🤦 Update all .Net refs to 8.0
🤖 Automatically merging PR
* Update staging lambda authorizer * Update dev auth arn --------- Co-authored-by: Adam <[email protected]>
Duslerke
reviewed
Apr 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.