unit-test: token/core/zkatdlog/nogh/v1/crypto #1354 - #1355
Merged
Conversation
unit-tests documentation Signed-off-by: Angelo De Caro <adc@zurich.ibm.com>
adecaro
force-pushed
the
1354-unit-test-tokencorezkatdlognoghv1crypto
branch
from
February 17, 2026 13:33
e56f3b9 to
f09b6ea
Compare
AkramBitar
approved these changes
Feb 17, 2026
AkramBitar
left a comment
AkramBitar
left a comment
Contributor
There was a problem hiding this comment.
LGTM.
Maybe for unit test coverage PRs, it’s worth specifying in the description how much coverage this PR adds. What do you think?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves: