validate proposal - #1362
Conversation
Signed-off-by: Hayim.Shaul@ibm.com <hayimsha@fhe3.haifa.ibm.com>
697d440 to
a132bbf
Compare
| // Validate that the token actions in the request are consistent with the proposal | ||
| // The token request should match what's in the transient data | ||
| // This ensures the relationship between the action, read-write set, and token actions | ||
| if len(request.RequestRaw) == 0 { |
There was a problem hiding this comment.
this is already checked in line 138
|
Hi @HayimShaul , thanks for submitting this PR. Some context to help with the resolution of the Issue. In the Fabric protocol, the endorser is responsible to check that who signed the proposal is known to the network. So, we need to double check if FSC (@mbrandenburger FYI) allows us to perform such a check. |
Signed-off-by: Hayim.Shaul@ibm.com <hayimsha@fhe3.haifa.ibm.com>
Signed-off-by: Hayim.Shaul@ibm.com <hayimsha@fhe3.haifa.ibm.com>
| }, nil | ||
| } | ||
|
|
||
| func (r *RequestApprovalResponderView) validateProposal(ctx view.Context, request *Request) error { |
There was a problem hiding this comment.
This is create functionality. We should come back to this function make is reusuable and provide it via FSC to any view.
4 participants
The new validateProposal() method verifies:
The fix closes a gap where the FSC endorser was not explicitly verifying that the Fabric proposal came from a legitimate, authenticated MSP member before endorsing it.