Skip to content

Bench fcs zkp - #1373

Merged
AkramBitar merged 1 commit into
mainfrom
bench-fcs-zkp
May 20, 2026
Merged

Bench fcs zkp#1373
AkramBitar merged 1 commit into
mainfrom
bench-fcs-zkp

Conversation

@Effi-S

@Effi-S Effi-S commented Feb 18, 2026

Copy link
Copy Markdown
Contributor

We are adding ZKP Benchmarking to test overhead of FSC nodes on TPS

@Effi-S Effi-S mentioned this pull request Feb 24, 2026
Closed
@AkramBitar AkramBitar linked an issue Feb 24, 2026 that may be closed by this pull request
Run ZKP Verification benchamark on Single endorser Perf Extended #1398
Closed
@AkramBitar AkramBitar added this to the Q1/26 milestone Feb 24, 2026
@AkramBitar
AkramBitar marked this pull request as draft February 24, 2026 10:53
@Effi-S
Effi-S force-pushed the bench-fcs-zkp branch 3 times, most recently from eefc01a to 2dc9e5f Compare February 26, 2026 12:44
github-code-quality[bot]
github-code-quality Bot found potential problems Mar 2, 2026
View reviewed changes
Comment thread cmd/benchmarking/plotly_plot_node.py Fixed
github-code-quality[bot]
github-code-quality Bot found potential problems Mar 3, 2026
View reviewed changes
Comment thread cmd/benchmarking/plotly_plot_node.py Fixed
@Effi-S
Effi-S force-pushed the bench-fcs-zkp branch 2 times, most recently from 6029aa0 to b8e8a5d Compare March 5, 2026 16:39
github-code-quality[bot]
github-code-quality Bot found potential problems Mar 9, 2026
View reviewed changes
Comment thread cmd/benchmarking/plotly_plot_node.py Fixed
@Effi-S
Effi-S force-pushed the bench-fcs-zkp branch 2 times, most recently from 3c5bbfd to b1591b6 Compare March 12, 2026 12:43
github-code-quality[bot]
github-code-quality Bot found potential problems Mar 26, 2026
View reviewed changes
Comment thread cmd/benchmarking/plotly_plot_node.py Fixed
@adecaro adecaro modified the milestones: Q1/26, Q2/26 Apr 2, 2026
This was linked to issues Apr 6, 2026
Run ZKP benchmarks on more physical cores #1380
Closed
ZKP Benchmarking in Single Endorser Node #1396
Closed
@AkramBitar AkramBitar modified the milestones: Q2/26, Q3/26 Apr 6, 2026
AkramBitar
AkramBitar requested changes Apr 16, 2026
View reviewed changes
Comment thread docs/drivers/benchmark/setting_up_nodes.md Outdated
Comment thread docs/drivers/benchmark/setting_up_nodes.md Outdated
Comment thread docs/drivers/benchmark/benchmark.md Outdated
Comment thread docs/drivers/benchmark/token_validation_service_benchmark.md
Comment thread docs/drivers/benchmark/token_validation_service_benchmark.md
Comment thread cmd/transfer_service/transfer_bench_test.go Outdated
Comment thread token/core/zkatdlog/nogh/v1/validator/bench/transfer_zk_only/server/main.go
Comment thread cmd/token_validation_service/out/cmd/test-node/main.go Outdated
Comment thread token/core/zkatdlog/nogh/v1/validator/bench/transfer_zk_only/server/main.go
Comment thread docs/drivers/benchmark/token_validation_service_benchmark.md
@AkramBitar
AkramBitar self-requested a review May 11, 2026 20:41
@AkramBitar
AkramBitar force-pushed the bench-fcs-zkp branch 2 times, most recently from 1a354f4 to a74dc3a Compare May 12, 2026 10:31
@AkramBitar

AkramBitar commented May 12, 2026

Copy link
Copy Markdown
Contributor

Hi, @adecaro I addressed your comments. Please let me know if you have more.

adecaro
adecaro reviewed May 12, 2026
View reviewed changes
Comment thread cmd/transfer_service/transfer_service_bench.go Outdated
adecaro
adecaro reviewed May 12, 2026
View reviewed changes
Comment thread docs/drivers/benchmark/token_validation_service_benchmark.md
adecaro
adecaro reviewed May 12, 2026
View reviewed changes
Comment thread cmd/transfer_service/transfer_service_bench.go Outdated
adecaro
adecaro reviewed May 12, 2026
View reviewed changes
Comment thread cmd/token_validation_service/out/cmd/test-node/main.go Outdated
@adecaro

adecaro commented May 12, 2026

Copy link
Copy Markdown
Contributor

I would suggest to create a go module for the new tool so that to isolate its dependencies from those of the token-sdk

@AkramBitar
AkramBitar force-pushed the bench-fcs-zkp branch 3 times, most recently from 8c0ea2f to f89f2dd Compare May 15, 2026 10:57
@AkramBitar
AkramBitar marked this pull request as ready for review May 16, 2026 18:28
@AkramBitar
AkramBitar force-pushed the bench-fcs-zkp branch 2 times, most recently from 2b61b70 to 8e940ef Compare May 19, 2026 11:04
@AkramBitar

AkramBitar commented May 19, 2026

Copy link
Copy Markdown
Contributor

I would suggest to create a go module for the new tool so that to isolate its dependencies from those of the token-sdk

Hi @adecaro,

I have addressed all your comments. This PR is ready to go from myside. Please let me know if you have any additional comment.

Thanks a lot.

@adecaro
adecaro self-requested a review May 19, 2026 12:52
adecaro
adecaro reviewed May 19, 2026
View reviewed changes
Comment thread docs/drivers/benchmark/token_validation_service_benchmark.md
adecaro
adecaro reviewed May 19, 2026
View reviewed changes
Comment thread docs/drivers/benchmark/token_validation_service_benchmark.md
@adecaro

adecaro commented May 19, 2026

Copy link
Copy Markdown
Contributor

Hi @AkramBitar , I left two more comments. In addition, we should update the Makefile's tidy entry to make sure go mod tidy is applied also there. I do believe, we need to update the FSC version in the go.mod of the tool to align it with the main go.mod.

Thanks for the effort 🙏

@AkramBitar

AkramBitar commented May 19, 2026

Copy link
Copy Markdown
Contributor

Hi @AkramBitar , I left two more comments. In addition, we should update the Makefile's tidy entry to make sure go mod tidy is applied also there. I do believe, we need to update the FSC version in the go.mod of the tool to align it with the main go.mod.

Thanks for the effort 🙏

Thanks a lot @adecaro for the comments . I addressed them.

@Effi-S AKRAM@il.ibm.com
Adding ZKP Benchmarking to test overhead of FSC nodes on TPS
d7e0c26 
Signed-off-by: Effi-S <effi.szt@gmail.com>
Signed-off-by: AKRAM@il.ibm.com <akram@akramb.vpc.cloud9.ibm.com>
@adecaro
adecaro self-requested a review May 20, 2026 08:30
adecaro
adecaro approved these changes May 20, 2026
View reviewed changes

@adecaro adecaro left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AkramBitar
AkramBitar merged commit f31dc4b into main May 20, 2026
96 checks passed
@adecaro
adecaro deleted the bench-fcs-zkp branch July 8, 2026 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adecaro adecaro adecaro approved these changes
@AkramBitar AkramBitar AkramBitar approved these changes
+1 more reviewer
@github-code-quality github-code-quality[bot] github-code-quality[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@Effi-S Effi-S

Labels

benchmark

Projects

None yet

Milestone

Q2/26

Development

Successfully merging this pull request may close these issues.

Run ZKP Verification benchamark on Single endorser Perf Extended ZKP Benchmarking in Single Endorser Node Run ZKP benchmarks on more physical cores

3 participants

@Effi-S @AkramBitar @adecaro