IssueMetadata#Match does not check issuer identity #1388 - #1389
Merged
adecaro merged 2 commits intoMar 2, 2026
Conversation
adecaro
marked this pull request as draft
February 20, 2026 15:38
adecaro
force-pushed
the
1388-issuemetadatamatch-does-not-check-issuer-identity
branch
5 times, most recently
from
February 21, 2026 06:28
bdb8df1 to
64f3780
Compare
adecaro
marked this pull request as ready for review
February 24, 2026 15:35
adecaro
force-pushed
the
1388-issuemetadatamatch-does-not-check-issuer-identity
branch
from
February 24, 2026 15:35
64f3780 to
8a6f1d1
Compare
AkramBitar
approved these changes
Feb 27, 2026
adecaro
force-pushed
the
1388-issuemetadatamatch-does-not-check-issuer-identity
branch
from
March 2, 2026 08:53
8a6f1d1 to
1082641
Compare
Add tests to achieve 100% coverage for token/metadata.go IssueMetadata#Match does not check issuer identity #1388 Signed-off-by: Angelo De Caro <adc@zurich.ibm.com>
adecaro
force-pushed
the
1388-issuemetadatamatch-does-not-check-issuer-identity
branch
from
March 2, 2026 10:36
1082641 to
d4c7aeb
Compare
adecaro
deleted the
1388-issuemetadatamatch-does-not-check-issuer-identity
branch
March 2, 2026 12:10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the bug described in #1388. It also makes sure the unit-test coverage is at 100%.