split token driver in two #864 - #1399
Merged
Merged
Conversation
adecaro
marked this pull request as draft
February 24, 2026 14:02
adecaro
force-pushed
the
issue-864-split-driver
branch
from
February 24, 2026 15:36
34f59ac to
c9a16c3
Compare
adecaro
force-pushed
the
issue-864-split-driver
branch
from
March 10, 2026 08:53
c9a16c3 to
5bed499
Compare
adecaro
force-pushed
the
issue-864-split-driver
branch
2 times, most recently
from
April 17, 2026 14:00
77f0f8a to
bfb85b5
Compare
adecaro
marked this pull request as ready for review
April 17, 2026 14:03
arner
reviewed
Apr 20, 2026
| } | ||
|
|
||
| // NewDefaultValidator returns a new instance of driver.Validator for the passed public parameters. | ||
| // TokenDriverService is an alias for TMSDriverService for backward compatibility. |
Contributor
There was a problem hiding this comment.
If you start the comment with // DEPRECATED: , it will be clear to users (even with warnings in the editor) that the new name is preferred.
adecaro
force-pushed
the
issue-864-split-driver
branch
3 times, most recently
from
April 22, 2026 04:35
f06d10a to
5d9d60d
Compare
arner
approved these changes
Apr 22, 2026
adecaro
force-pushed
the
issue-864-split-driver
branch
2 times, most recently
from
April 23, 2026 04:50
806ae41 to
f672e68
Compare
Signed-off-by: Angelo De Caro <adc@zurich.ibm.com> # Conflicts: # docs/driverapi.md # token/core/fabtoken/v1/driver/base.go # token/core/zkatdlog/nogh/v1/driver/base.go
Signed-off-by: Angelo De Caro <adc@zurich.ibm.com>
Signed-off-by: Angelo De Caro <adc@zurich.ibm.com>
Signed-off-by: Angelo De Caro <adc@zurich.ibm.com>
Signed-off-by: Angelo De Caro <adc@zurich.ibm.com>
adecaro
force-pushed
the
issue-864-split-driver
branch
from
April 23, 2026 06:36
f672e68 to
c40e2cf
Compare
sid200727
pushed a commit
to sid200727/fabric-token-sdk
that referenced
this pull request
Apr 24, 2026
Signed-off-by: Angelo De Caro <adc@zurich.ibm.com> Signed-off-by: Siddhi Khandelwal <siddhi.200727@gmail.com>
sid200727
pushed a commit
to sid200727/fabric-token-sdk
that referenced
this pull request
Apr 24, 2026
Signed-off-by: Angelo De Caro <adc@zurich.ibm.com> Signed-off-by: Siddhi Khandelwal <siddhi.200727@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR should make it easier to extends the validator side of a token driver.