Cache verifiers to eliminate duplicate Idemix proofs - #1410
Closed
AkramBitar wants to merge 1 commit into
Closed
Conversation
AkramBitar
marked this pull request as draft
March 3, 2026 12:55
AkramBitar
force-pushed
the
validator-verifier-cache
branch
from
March 3, 2026 13:03
ab8b7ef to
4c69873
Compare
AkramBitar
marked this pull request as ready for review
March 3, 2026 14:23
AkramBitar
force-pushed
the
validator-verifier-cache
branch
4 times, most recently
from
March 3, 2026 20:06
a05ac81 to
a430068
Compare
Contributor
Author
|
There is a bug in the benchmark the input tokens should have different identity. Thus, in ZKP driver this could not be. Will put this PR in draft until and check if we can have caching to improve FBA token driver. |
AkramBitar
marked this pull request as draft
March 6, 2026 13:47
Signed-off-by: AkramBitar <akram@il.ibm.com>
AkramBitar
force-pushed
the
validator-verifier-cache
branch
from
March 9, 2026 21:34
52e9dcf to
e007746
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Proposal 1: #1403 (comment)
This fix can reduce ~3 ms of ~31ms (~9.6% improvements) of token transfer validation in the Fabric Token SDK, where the input tokens owned by the same Idemix identity.
Example:
2 input tokens (both owned by the same Idemix identity - Alice)
2 output tokens - Bob
Input[0]: Owner = Alice (identity bytes: 0xABCD...)
Input[1]: Owner = Alice (identity bytes: 0xABCD...) ← SAME bytes