feat(identity_service): check identity DB if a lookup fails #1415 - #1416
Merged
adecaro merged 17 commits intoMar 20, 2026
Merged
Conversation
adecaro
marked this pull request as draft
March 10, 2026 14:20
adecaro
force-pushed
the
1415-featidentity_service-check-identity-db-if-a-lookup-fails
branch
from
March 10, 2026 14:46
9f1936e to
ac970a2
Compare
adecaro
force-pushed
the
1415-featidentity_service-check-identity-db-if-a-lookup-fails
branch
3 times, most recently
from
March 11, 2026 12:33
d92bcc8 to
98e909d
Compare
adecaro
marked this pull request as ready for review
March 12, 2026 14:59
adecaro
force-pushed
the
1415-featidentity_service-check-identity-db-if-a-lookup-fails
branch
4 times, most recently
from
March 13, 2026 13:00
1c371fb to
472732e
Compare
AkramBitar
requested changes
Mar 13, 2026
| return nil, err | ||
| } | ||
|
|
||
| return d.IdentityNotifier.Get(*opts) |
Contributor
There was a problem hiding this comment.
I am wondering if we need to add unit test for this file also the same comments for other files go file in driver, kvs, memory, postgres, sqlite, etc.
Contributor
Author
There was a problem hiding this comment.
good point, will add.
adecaro
force-pushed
the
1415-featidentity_service-check-identity-db-if-a-lookup-fails
branch
from
March 16, 2026 12:33
472732e to
15b64f3
Compare
adecaro
force-pushed
the
1415-featidentity_service-check-identity-db-if-a-lookup-fails
branch
2 times, most recently
from
March 16, 2026 13:04
677f56a to
7bd9a32
Compare
AkramBitar
approved these changes
Mar 17, 2026
adecaro
force-pushed
the
1415-featidentity_service-check-identity-db-if-a-lookup-fails
branch
4 times, most recently
from
March 20, 2026 10:26
35d5092 to
b13d56e
Compare
Signed-off-by: Angelo De Caro <adc@zurich.ibm.com>
Signed-off-by: Angelo De Caro <adc@zurich.ibm.com>
Signed-off-by: Angelo De Caro <adc@zurich.ibm.com>
Signed-off-by: Angelo De Caro <adc@zurich.ibm.com>
Signed-off-by: Angelo De Caro <adc@zurich.ibm.com>
Signed-off-by: Angelo De Caro <adc@zurich.ibm.com> # Conflicts: # go.mod # Conflicts: # go.mod
Signed-off-by: Angelo De Caro <adc@zurich.ibm.com>
Signed-off-by: Angelo De Caro <adc@zurich.ibm.com>
Signed-off-by: Angelo De Caro <adc@zurich.ibm.com>
Signed-off-by: Angelo De Caro <adc@zurich.ibm.com>
Signed-off-by: Angelo De Caro <adc@zurich.ibm.com>
Signed-off-by: Angelo De Caro <adc@zurich.ibm.com>
Signed-off-by: Angelo De Caro <adc@zurich.ibm.com>
adecaro
force-pushed
the
1415-featidentity_service-check-identity-db-if-a-lookup-fails
branch
from
March 20, 2026 10:27
b13d56e to
743b900
Compare
adecaro
deleted the
1415-featidentity_service-check-identity-db-if-a-lookup-fails
branch
March 20, 2026 12:03
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #1415 by introducing a notification service for the identity table. The notification service is provided by the smart client. In this PR we instantiate it to track the additions performed to the identity table. Upon an event, the membership service registers the new identity.