Fix: handle NOT_VALIDATED status in ledger.Status() - #1417
Merged
adecaro merged 1 commit intoMar 11, 2026
Merged
Conversation
Signed-off-by: atharrva01 <atharvaborade568@gmail.com>
Contributor
Author
|
hi @adecaro I noticed ledger.Status() didn’t handle the NOT_VALIDATED state, which could cause pending transactions to be reported as Invalid. This adds the missing case so they return Unknown, matching the behavior of the finality service. |
Contributor
|
Hi @atharrva01, nice catch. I'll review ASAP. Thanks for submitting this. |
adecaro
self-requested a review
March 11, 2026 08:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
I noticed that
ledger.Status()in the FabricX package doesn’t handle theNOT_VALIDATEDstate. When a transaction is still waiting to be committed (which can happen during normal block processing or orderer delays), it falls into the default case and gets marked asInvalid, even though it hasn’t failed.Interestingly, the finality service in the same package already handles this correctly:
So right now two parts of the system interpret the same state differently.
Impact
Invalideven though they are still in-flightLedger.Status()might interpret the result as a failure, even though the transaction is simply not validated yetFix
I added the missing
NOT_VALIDATEDcase so pending transactions returnUnknown. It’s a small change but keepsledger.Status()consistent with the finality service and avoids false failure signals.