Skip to content

tokens: transactional core is untested and the package carries dead declarations and an unused generated mock #2214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Effi-S wants to merge 1 commit into
base: main
Choose a base branch
from
Open

tokens: transactional core is untested and the package carries dead declarations and an unused generated mock #2214

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion token/services/tokens/generate.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ package tokens
//go:generate counterfeiter -o mock/tms_provider.go . TMSProvider
//go:generate counterfeiter -o mock/network_provider.go . NetworkProvider
//go:generate counterfeiter -o mock/metadata.go . MetaData
//go:generate counterfeiter -o mock/transaction.go . Transaction
//go:generate counterfeiter -o mock/cache.go . Cache

// External and shared interfaces
Expand Down
353 changes: 0 additions & 353 deletions token/services/tokens/mock/transaction.go
View file
Open in desktop

This file was deleted.

20 changes: 0 additions & 20 deletions token/services/tokens/tokens.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,26 +30,6 @@ type MetaData interface {
SpentTokenID() []*token2.ID
}

// GetTMSProviderFunc is a function type that returns a token management service provider.
type GetTMSProviderFunc = func() *token.ManagementServiceProvider

// UnspendableTokensIterator is an alias for the driver's UnsupportedTokensIterator.
type UnspendableTokensIterator = driver.UnsupportedTokensIterator

// Transaction models a token transaction within Panurus, providing access to its identifiers and request content.
type Transaction interface {
// ID returns the transaction identifier.
ID() string
// Network returns the network name the transaction belongs to.
Network() string
// Channel returns the channel name.
Channel() string
// Namespace returns the namespace (chaincode ID) of the transaction.
Namespace() string
// Request returns the underlying token request.
Request() *token.Request
}

// Cache defines the interface for caching token requests and their extracted actions.
type Cache interface {
// Get retrieves a cache entry by key.
Expand Down
Loading
Loading