Skip to content

fix(storage): keep token amounts exact instead of truncating to uint64 #2221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AkramBitar wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(storage): keep token amounts exact instead of truncating to uint64 #2221

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b63f3fa
fix(storage): keep token amounts exact instead of truncating to uint64
AkramBitar Aug 13, 2026
923d766
refactor(storage): assert amount validation via sentinel errors
AkramBitar Aug 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion token/services/selector/testutils/test_cases.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ package testutils
import (
"context"
"fmt"
"math/big"
"sync"
"sync/atomic"
"testing"
Expand Down Expand Up @@ -173,7 +174,7 @@ func (m *enhancedManager) UpdateTokens(deleted []*token.ID, added []token.Unspen
LedgerMetadata: []byte{},
Quantity: t.Quantity,
Type: t.Type,
Amount: 0,
Amount: big.NewInt(0),
Owner: true,
Auditor: false,
Issuer: false,
Expand Down
3 changes: 2 additions & 1 deletion token/services/storage/db/dbtest/tokenlock.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ SPDX-License-Identifier: Apache-2.0
package dbtest

import (
"math/big"
"testing"
"time"

Expand Down Expand Up @@ -79,7 +80,7 @@ func TestFully(t *testing.T, tokenDB driver3.TokenStore, tokenLockDB driver3.Tok
LedgerMetadata: []byte{}, // Empty metadata
Quantity: "0x64", // 100 in hex
Type: "USD",
Amount: 100,
Amount: big.NewInt(100),
Owner: true,
}
err = tokenTx.StoreToken(ctx, tokenRecord, []string{"owner1"})
Expand Down
Loading
Loading