Workflows do not restrict GITHUB_TOKEN permissions (Scorecard Token-Permissions) - #2223
Merged
Conversation
Contributor
|
LGTM |
Signed-off-by: Effi-S <effi.szt@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2219
OpenSSF Scorecard reports a Token-Permissions finding (severity: high, score 0) against several GitHub Actions workflows: no top-level
permissionsblock is defined, so theGITHUB_TOKENin these workflows runs with the repository/organization default scopes rather than the least privilege each workflow actually needs.Impact
Without an explicit least-privilege
permissionsdeclaration, a compromised action, dependency, or injected step in these workflows would inherit broad write access to the repository (contents, pull requests, issues, packages, etc.). This widens the blast radius of any supply-chain or workflow compromise and keeps the repository's Scorecard security posture below its potential.Affected workflows
.github/workflows/tests.yml.github/workflows/protect-integration-test-types.yml.github/workflows/md_links.yml.github/workflows/codeql-analysis.ymlReported by code scanning (Scorecard) alerts #150, #151, #152, #153.