fix(storage): align keystore cleanup semantics, error chains and facade tests - #2248
Merged
Conversation
AkramBitar
marked this pull request as draft
August 17, 2026 19:15
AkramBitar
force-pushed
the
fix/2045-facades-findings
branch
from
August 18, 2026 07:05
d7c50de to
891263a
Compare
AkramBitar
marked this pull request as ready for review
August 18, 2026 07:09
AkramBitar
requested review from
Effi-S,
HayimShaul,
SaidAltury-ibm and
adecaro
August 18, 2026 07:09
Effi-S
approved these changes
Aug 18, 2026
…de tests (#2045) Signed-off-by: AkramBitar <akram@il.ibm.com>
AkramBitar
force-pushed
the
fix/2045-facades-findings
branch
from
August 18, 2026 10:31
1fe963e to
ca9879a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2045
Five small problems in the token storage code.
5 bugs/gaps in token storage cleanup, all in
token/services/storage/:%son an error killserrors.IsdownstreamendorserdbandtokenlockdbRollback()afterCommit()fail — unreachable code, removed