Make the 'prettyJson' option work #75
Merged
+1
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duplicated `options.add`, which added `true` to the command line (the return value of `options.add()`). The command fails with: _unrecognized "true"_. This PR proposes to fix this issue by not implicitly adding the additional `ASM_JSON` output. As `prettyJson = true` also makes sense in combination with other outputs such as `ABI`. Signed-off-by: Jendrik Johannes <[email protected]>
Signed-off-by: gtebrean <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
options.add(options.add("--$OutputComponent.ASM_JSON"))contained a duplicatedoptions.add, which addedtrueto the command line (the return value ofoptions.add()). The command fails with: unrecognized "true".This PR proposes to fix this issue by not implicitly adding the additional
ASM_JSONoutput. AsprettyJson = truealso makes sense in combination with other outputs such asABI.Where should the reviewer start?
n/a
Why is it needed?
prettyJson = trueis currently not working. It always leads to a broken compiler call.Checklist