fix: check --all-features option in CI and fix identified issues#323
Merged
cedricchevalier19 merged 6 commits intoMar 23, 2026
Merged
Conversation
this needs testing, the `*mut i64` conversions seem very weird to me, but the original `*mut u8` also were...
my mistake, I added it for the lsp to diagnostic correctly
also, don't run tests with all features since there's no avx512 on regular GH runners
cedricchevalier19
approved these changes
Mar 23, 2026
cedricchevalier19
merged commit 30dce98
into
LIHPC-Computational-Geometry:master
4 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The build CI was not checking builds with all features enabled, so it was missing some errors in builds using
avx512ormetis. I added another step to the workflow with the--all-featuresoption to catch those.I also fixed the issues.