fix inc_lr and dec_lr overflow#454
Open
remind-me-later wants to merge 2 commits intoLIJI32:masterfrom
Open
Conversation
jkotlinski
reviewed
Aug 6, 2022
| register_id = (opcode >> 4) + 1; | ||
|
|
||
| value = (gb->registers[register_id] & 0xFF) + 1; | ||
| value = (gb->registers[register_id] + 1) & 0xFF; |
Contributor
There was a problem hiding this comment.
The & 0xff part is redundant, as the value is implicitly casted to uint8_t.
LIJI32
force-pushed
the
master
branch
4 times, most recently
from
4ebe973 to
0989ee2
Compare
LIJI32
force-pushed
the
master
branch
2 times, most recently
from
4873d7c to
858f003
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think the old version could overflow changing the value of the high register, but worked fine. I'm sorry if this is another instance of C doing some implicit casting I'm not seeing.