Skip to content

Ale3d #335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 45 commits into
base: develop
Choose a base branch
from
Open

Ale3d #335

wants to merge 45 commits into from

Conversation

ptsuji
Copy link
Collaborator

@ptsuji ptsuji commented Mar 24, 2025 •
edited
Loading

Summary

  • Merge back ALE3D changes
    • Missing headers in CMakeLists.txt files
    • Use of threadCopy variables in SolidCRKSPHRZ (picked up by thread sanitizer tests)
    • Use CXXONLY macro to affect time step reporting (no allReduce, no longitudinal sound speed)

ToDo :

  • Annotate RELEASE_NOTES.md with notable changes.
  • Create LLNLSpheral PR pointing at this branch. (PR#)
  • LLNLSpheral PR has passed all tests.

adayton1 and others added 30 commits July 26, 2024 16:40
@adayton1
Move computeSPHVolume to Hydro package
e24425b
@adayton1
Move ReplaceWithRatioPolicy from GSPH to DataBase
dae95b3
@adayton1
Make GSPH an optional package
09b0014
@adayton1
Add filter for gsph tests
1686548
@adayton1
Add gsph filter to tests
c6c46c2
@adayton1
Fix typo
419f597
@adayton1
Fix merge conflicts
2ae54b0
@adayton1
Fix ordering
79b1f26
@ptsuji
Merge branch 'pristine' into feature/tsuji1/spheral
54ea9d1
@ptsuji
Merge branch 'pristine' into feature/tsuji1/spheral
bba0a70
@ptsuji
Recommitting the Windows project files, since they are now removed from
7a386a7 
the Spheral github repo.
@adayton1
Merge branch 'develop' into feature/dayton8/optional_gsph
ba46371
@adayton1
Remove extra header
adc3b2a
@ptsuji
Merge branch 'feature/dayton8/optional_gsph' of https://github.com/LL…
f0ad109 
…NL/spheral into feature/tsuji1/spheral
@ptsuji
Adding the two instantiations to the Windows project files.
0bd063f
@AlbertNichols3
Fix serial build in windows
5fffc9c
@ptsuji
Merge branch 'pristine' into feature/tsuji1/spheral
7815262
@AlbertNichols3
Merge branch 'ale3d' into bugfix/nichols/visit
b2bb708
@ptsuji
Merge branch 'feature/ASPHv2' of https://github.com/LLNL/spheral into…
88a672d 
… feature/tsuji1/spheral
@ptsuji
Merge branch 'pristine' into feature/tsuji1/spheral
4ea3903
@ptsuji
Merge branch 'feature/ASPHv2' of https://github.com/LLNL/spheral into…
560a224 
… feature/tsuji1/spheral
@ptsuji
Merge branch 'feature/ASPHv2' of https://github.com/LLNL/spheral into…
3922f43 
… feature/tsuji1/spheral
@liu15
Fix spheral for out-of-source
abaa263
@liu15
Fix hypre refs
251e904
@ptsuji
Merge branch 'feature/ASPHv2' of https://github.com/LLNL/spheral into…
125d8e5 
… feature/tsuji1/spheral
@ptsuji
Merge branch 'feature/ASPHv2' of https://github.com/LLNL/spheral into…
0905e01 
… feature/tsuji1/spheral
@ptsuji
Merge branch 'feature/ASPHv2' of https://github.com/LLNL/spheral into…
e22b5e1 
… feature/tsuji1/spheral
@adayton1
Fix race condition in spheral and old DSD
badf7d5
@adayton1
Disable openmp loops in spheral with data races
f0d0f7c
@adayton1
Comment out openmp loops in spheral with data races
66ef1c0
adayton1 and others added 15 commits December 2, 2024 09:43
@adayton1
Revert spheral changes in favor of suppressions
cf7480c
@ptsuji
Merge branch 'pristine' into feature/tsuji1/spheral
017b3c0
@ptsuji
Merge remote-tracking branch 'origin/feature/tsuji1/spheral' into fea…
eeeb9b1 
…ture/tsuji1/spheral
@ptsuji
Checkpoint for windows build of Spheral.
1b0ef15
@ptsuji
Last fixes for the Spheral windows build.
9f15764
@ptsuji
Merge branch 'feature/pip-runtime-deps' of https://github.com/LLNL/sp…
1b3608e 
…heral into feature/tsuji1/spheral
@ptsuji
Merge branch 'pristine' into feature/tsuji1/spheral
a100ac9
@ptsuji
Merge branch 'feature/ArtificialViscosityPackage' of https://github.c…
9f06dac 
…om/LLNL/spheral into feature/tsuji1/spheral
@ptsuji
Merge branch 'feature/ArtificialViscosityPackage' of https://github.c…
741d2d2 
…om/LLNL/spheral into feature/tsuji1/spheral
@ptsuji
Adding some missing headers when we include Neighbor/PairwiseField.hh.
0c7c7b0
@ptsuji
Merge branch 'pristine' into feature/tsuji1/spheral
b8ee72b
@ptsuji
Updates to Windows project files.
de9cb1a
@ptsuji
By default do the reduction of the time step, but for the interface,
efd3d05 
we need the dt guess on each local process.
@ptsuji
Fix for thread sanitizer tests. The threadCopy arrays were not being …
f4e085f 
…used.
@ptsuji
Use CXXONLY ifdef to modify these parts.
0b93ff2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ptsuji @adayton1 @AlbertNichols3 @liu15