Feautre/adapt opt #565
Merged
Feautre/adapt opt #565
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… included with SUNDIALS
…t_X_mriadapt.cpp unit tests to support new single-rate controllers via command-line arguments
|
FYI, after discussing this topic with Sylvia, I realized that in fact I should have implemented both the H312 and H0321 controllers - while I included both in the FAQ, I'd only implemented the simplified constructor for H312. I just added H0321 as well to complete the implementation. |
gardner48
added a commit
to sundials-codes/answers
that referenced
this pull request
Apr 4, 2025
Update answer files for LLNL/sundials#565 --------- Co-authored-by: Steven Roberts <[email protected]>
gardner48
approved these changes
Apr 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft status while doing performance comparisons.
This branches of off
feature/rk_defaultswithfeature/min-errmerged in.Current adaptivity controller changes: