-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feautre/adapt opt #565
Draft
Steven-Roberts
wants to merge
101
commits into
feature/rk_defaults
Choose a base branch
from
feautre/adapt-opt
base: feature/rk_defaults
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Feautre/adapt opt #565
+118,659
−11,022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add acknowledgements to README and online docs landing page
Add new warnings flags for gcc and clang. --------- Co-authored-by: David Gardner <[email protected]>
Add operator splitting stepper module to ARKODE ----- Co-authored-by: David Gardner <[email protected]> Co-authored-by: Daniel R. Reynolds <[email protected]> Co-authored-by: Cody Balos <[email protected]> Co-authored-by: Balos, Cody, J <[email protected]>
Fix out of bounds read when setting MRI stage type
* Fix memory leak when attaching an H-Tol controller to MRIStep * Fix memory leak / out of bound array access in Lagrange interpolation module * Fix memory leaks in unit tests
Fix a bug in SPRKStep where `yerr` was not initialized to zero when using compensated summations
Add missing 32-bit ``sunindextype`` Fortran interface functions for * ``N_VGetSubvectorArrayPointer_ManyVector`` * ``N_VGetSubvectorArrayPointer_MPIManyVector`` * ``SUNBandMatrix_Column`` * ``SUNDenseMatrix_Column``
Fix a bug when enabling rootfinding with fixed step sizes and the initial value of the rootfinding function is zero. In this case, uninitialized right-hand side data (`fn`) is used to compute a forward Euler step to get a state near the initial condition to determine if any rootfinding functions are active at the initial condition.
Fix dissipated entropy example: * Vector and matrix size * Initial condition * Answer function --------- Co-authored-by: Cody Balos <[email protected]>
Add test without TPLs to run CI with the address sanitizer enabled --------- Co-authored-by: Cody Balos <[email protected]>
Update set function name to be consistent with `SetNum` naming convention
Fix SYCL vector build with 2025 oneAPI compilers. Fix for #596 --------- Co-authored-by: David Gardner <[email protected]>
Follow on to utilities added in #499 * Make info logging output in the integrators more consistent * Update parser for MRI and operator splitting methods * Add function to extract lists of data for plotting * Add example scripts using log parser --------- Co-authored-by: Steven Roberts <[email protected]> Co-authored-by: Daniel R. Reynolds <[email protected]> Co-authored-by: Cody Balos <[email protected]>
SUNDIALS Release v7.2.0
Updates to start the next release cycle on develop
Move vector, matrix, linear solver, and nonlinear solver tests to unit test directory ----- Co-authored-by: David Gardner <[email protected]>
Create separate sections for documenting source code and documentation in the developer guide
Remove mostly unused force_variable CMake macro
Remove wrappers that were originally part of a C90 workaround and are no longer needed now that C99 is required
Fix a bug in ARKStep where an extra right-hand side evaluation occurs each time step when enabling the ``ARKodeSetAutonomous`` option and using an IMEX method where the DIRK table has an implicit first and is not stiffly accurate. Fix a bug in counting the number of explicit RHS evaluations in the ARKStep Dahlquist unit test. --------- Co-authored-by: Daniel R. Reynolds <[email protected]>
* Always enable testing * Consistent naming of CMake testing options * Add warnings/errors for some testing option combinations * Add documentation for testing options * Move testing README into testing docs * Cleanup using default testing options * Enable running test in containers without enabling development tests * Simplify setting pre and post executable run commands/options in sundials_add_test * Remove redundant Jenkins tests * Remove precision dependent diff option in unit tests
SUNDIALS Release v7.2.1 --------- Co-authored-by: Cody Balos <[email protected]> Co-authored-by: Daniel R. Reynolds <[email protected]>
Update recent changes for next release cycle
Update release checklist ----- Co-authored-by: David Gardner <[email protected]>
Adding a status badge for the workflow that tracks downloads in https://github.com/sundials-codes/sundials-download-tracker. This will make it readily apparent when there is an issue tracking downloads. See sundials-codes/sundials-download-tracker#1.
Fix version numbers in the install guide Fix scripts to automatically update version numbers Fix typo in version changed directive
Only zero yerr when compensated summation is enabled ----- Co-authored-by: David J. Gardner <[email protected]>
Bumps [docker/build-push-action](https://github.com/docker/build-push-action) from 6.10.0 to 6.11.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/docker/build-push-action/releases">docker/build-push-action's releases</a>.</em></p> <blockquote> <h2>v6.11.0</h2> <ul> <li>Handlebar <code>defaultContext</code> support for <code>build-contexts</code> input by <a href="https://github.com/crazy-max"><code>@crazy-max</code></a> in <a href="https://redirect.github.com/docker/build-push-action/pull/1283">docker/build-push-action#1283</a></li> <li>Bump <code>@docker/actions-toolkit</code> from 0.46.0 to 0.49.0 in <a href="https://redirect.github.com/docker/build-push-action/pull/1281">docker/build-push-action#1281</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/docker/build-push-action/compare/v6.10.0...v6.11.0">https://github.com/docker/build-push-action/compare/v6.10.0...v6.11.0</a></p> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/docker/build-push-action/commit/b32b51a8eda65d6793cd0494a773d4f6bcef32dc"><code>b32b51a</code></a> Merge pull request <a href="https://redirect.github.com/docker/build-push-action/issues/1281">#1281</a> from docker/dependabot/npm_and_yarn/docker/actions-t...</li> <li><a href="https://github.com/docker/build-push-action/commit/594bf46f0f6d32fd8bd98a553127950004165c96"><code>594bf46</code></a> Merge pull request <a href="https://redirect.github.com/docker/build-push-action/issues/1294">#1294</a> from crazy-max/fix-e2e</li> <li><a href="https://github.com/docker/build-push-action/commit/fd37bd55af0b8c458ea0ff376ce151a332fa7aed"><code>fd37bd5</code></a> ci(e2e): fix setup docker config</li> <li><a href="https://github.com/docker/build-push-action/commit/e6478a2405f3527f33b93efb6857519c3ffd91f2"><code>e6478a2</code></a> chore: update generated content</li> <li><a href="https://github.com/docker/build-push-action/commit/78785bddff35ca36f384e0c6a8a367584317df9f"><code>78785bd</code></a> chore(deps): Bump <code>@docker/actions-toolkit</code> from 0.46.0 to 0.49.0</li> <li><a href="https://github.com/docker/build-push-action/commit/128779fed7edb034b3f8006e9dac81a8593c040e"><code>128779f</code></a> Merge pull request <a href="https://redirect.github.com/docker/build-push-action/issues/1283">#1283</a> from crazy-max/named-context-handlebars</li> <li><a href="https://github.com/docker/build-push-action/commit/7e094594beda23fc8f21fa31049f4b203e51096b"><code>7e09459</code></a> Merge pull request <a href="https://redirect.github.com/docker/build-push-action/issues/1282">#1282</a> from crazy-max/remove-buildkit-5561</li> <li><a href="https://github.com/docker/build-push-action/commit/32ee877a58507615d974839965ef8e530d66362e"><code>32ee877</code></a> Revert "init buildkit-5561 workflow"</li> <li><a href="https://github.com/docker/build-push-action/commit/d1a4129c41bb3f92b731b33dc29cfe5f6cd9298f"><code>d1a4129</code></a> chore: update generated content</li> <li><a href="https://github.com/docker/build-push-action/commit/49c623eaf82513814393adabc13bf2535384d735"><code>49c623e</code></a> handlebar defaultContext support for build-contexts input</li> <li>Additional commits viewable in <a href="https://github.com/docker/build-push-action/compare/v6.10.0...v6.11.0">compare view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=docker/build-push-action&package-manager=github_actions&previous-version=6.10.0&new-version=6.11.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft status while doing performance comparisons.
This branches of off
feature/rk_defaults
withfeature/min-err
merged in.Current adaptivity controller changes: