Skip to content

upgrade to java 17#16

Merged
markus-lmax merged 1 commit into
masterfrom
java-gradle-upgrade
Oct 13, 2025
Merged

upgrade to java 17#16
markus-lmax merged 1 commit into
masterfrom
java-gradle-upgrade

Conversation

@markus-lmax

Copy link
Copy Markdown
Collaborator

which requires upgrading gradle and mockito as well

which requires upgrading gradle and mockito as well
@markus-lmax

Copy link
Copy Markdown
Collaborator Author

Review comment from Daniel Milnes (@thebeanogamer):

Is there a reason you've gone with v3 of gradle/actions/setup-gradle instead of the latest v5?

I tried using the latest v5, but running that locally with https://github.com/nektos/act failed with

[Java CI with Gradle/build]   ☁  git clone 'https://github.com/gradle/actions' # ref=v5
[Java CI with Gradle/build] Unable to resolve v5: unsupported object type

Given act correctly pointed out an actual issue earlier in the process and passed after I had fixed that, I trust the tool enough to leave everything as-is. Perhaps v5 only supports later gradle versions 🤷.

@markus-lmax
markus-lmax merged commit df8739f into master Oct 13, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant