Add missing KaTeX macros \GammaL, \GammaU, \SigmaL, \SigmaSp - #7151
Open
roed-math wants to merge 2 commits into
Open
Add missing KaTeX macros \GammaL, \GammaU, \SigmaL, \SigmaSp#7151roed-math wants to merge 2 commits into
roed-math wants to merge 2 commits into
Conversation
Group pages for groups whose elements are displayed in a projective Lie family (PGammaL, PGammaU, PSigmaL, PSigmaSp) strip the leading P in repr_strg, emitting \GammaL / \GammaU / \SigmaL / \SigmaSp, which base.html did not define, so e.g. /Groups/Abstract/51840.b showed raw \GammaU(4,2). Audited every macro used in devmirror gps_groups tex columns, gps_subgroup_search tex columns (sampled), gps_families.tex_name and the Lie families in representations; these four were the only missing legitimate macros. Added them in the style of the existing P-family macros plus a regression test; verified in a local server that 51840.b renders the sentence as matrices in GammaU(4,2) with zero katex-error nodes. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Contributor
|
This is fine. It adds a test to check for these particular macros which is probably excessive but won't cause problems. Note Claude also surfaced a data error with \PSOPlusPlus(4,3) (the double plus). If you agree the best option is to fix the data @roed314, I can go ahead and make that data fix. Or is there a reason for the double Plus? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #7048.
Group pages describing elements of a projective Lie-family group strip the leading P from the family name (
repr_strginweb_groups.py), emitting\GammaU(4,2)etc., butbase.htmlonly defined the P-forms, so e.g. 51840.b showed a raw\GammaU. This adds the four missing macros in the style of their existing\PGammaL-family siblings, plus a regression test.An audit of every
\macrotoken in the devmirrorgps_groups/gps_familiestex columns, a sample ofgps_subgroup_searchtex columns, and all Lie families inrepresentationsconfirms these four were the only missing legitimate macros.The audit also surfaced
\PSOPlusPlus(4,3)(two aut_tex rows: 11520.be, 13824.dn; and roughly 25k subgroup_tex rows), a duplicated-"Plus" data-generation bug: the leading factor has order 288 = |PSO+(4,3)| and no such family exists in the naming code. That should be fixed in the data rather than masked with a macro.Ported from roed-math#14, where the full write-up and comment history live.
🤖 Generated with Claude Code