Preserve value of midiautoassign when MIDI device is disconnected. #7833
+6
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AW1534
changed the title
|
merged into #7863 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, if the selected MIDI device is disconnected, it would show up as "none", which is fine, but upon clicking "ok" (whether a change is made to the preferences or not) would reset the choice because it saves each input.
sorry if this description isn't very clear, I can provide a video demonstration of the old behaviour.
This PR simply fixes this by keeping the user selected midi device in the drop-down (which has the same behaviour as none). Then if the device is reconnected, it can be used without having to be reselected.
untitled.mp4